feat: add a couple of build commands #1055
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
force-pushed
the
henryiii/feat/buildcom
branch
3 times, most recently
from
d70da64 to
be5fa18
Compare
Collaborator
Author
|
Any thoughts on a better name for "metadata"? I don't like that one. It evaluates the dynamic metadata then returns the updated project table in JSON form. |
Collaborator
For me Metadata would be the |
Signed-off-by: Henry Schreiner <[email protected]>
Signed-off-by: Henry Schreiner <[email protected]>
henryiii
force-pushed
the
henryiii/feat/buildcom
branch
from
be5fa18 to
5ab29f0
Compare
Contributor
There was a problem hiding this comment.
Pull Request Overview
This PR introduces experimental build commands to provide build requirements and dynamic project metadata. Key changes include:
- Updating tests to capture warnings/errors from stderr instead of stdout.
- Adding new CLI commands ("requires" and "project-table") in the build module.
- Enhancing logging functions in the _logging module to allow directing output to a specified file.
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/test_skbuild_settings.py | Updated stderr capture in tests for cmake warnings. |
| tests/test_printouts.py | Applied type annotations and added future import for annotations. |
| tests/test_build_cli.py | Added tests for both the build requirements and project metadata commands. |
| tests/test_broken_fallback.py | Updated fallback test to capture stderr output correctly. |
| src/scikit_build_core/build/main.py | Introduced new CLI commands for "requires" and "project-table". |
| src/scikit_build_core/_logging.py | Modified rich_warning and rich_error to enable file specification. |
| pyproject.toml | Extended file patterns to include main.py files. |
Comments suppressed due to low confidence (1)
src/scikit_build_core/_logging.py:348
- Ensure that 'sys' is explicitly imported in this module since sys.stderr is referenced (e.g., in rich_warning and rich_error) to prevent potential NameError issues.
file: object = None,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a couple of potentially useful build commands:
"requires" prints out the full build requirements. "project-table" reads the project table, runs dynamic metadata, and then prints the new project table in json form; it may need the requirements installed (which is why I added both commands).
Like the other commands, these are somewhat experimental and subject to change.
Warning/error messages now print to stderr.